From ab7784092fab37fabf50f0387222f2b14914bca6 Mon Sep 17 00:00:00 2001 From: HypherionMC Date: Sun, 1 Oct 2023 00:04:56 +0200 Subject: [PATCH] [BUG] Fix Forge Network Handler --- .../craterlib/network/ForgeNetworkHandler.java | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/Forge/src/main/java/com/hypherionmc/craterlib/network/ForgeNetworkHandler.java b/Forge/src/main/java/com/hypherionmc/craterlib/network/ForgeNetworkHandler.java index 72f3f1a..6eb4d69 100644 --- a/Forge/src/main/java/com/hypherionmc/craterlib/network/ForgeNetworkHandler.java +++ b/Forge/src/main/java/com/hypherionmc/craterlib/network/ForgeNetworkHandler.java @@ -115,12 +115,17 @@ public class ForgeNetworkHandler implements CraterNetworkHandler { } private static SimpleChannel buildSimpleChannel(String modId, boolean clientAcceptsVanillaOrMissing, boolean serverAcceptsVanillaOrMissing) { - return ChannelBuilder - .named(new ResourceLocation(modId, "crater_network")) - .networkProtocolVersion(1) - .clientAcceptedVersions(clientAcceptsVanillaOrMissing ? Channel.VersionTest.ACCEPT_MISSING : Channel.VersionTest.exact(1)) - .serverAcceptedVersions(serverAcceptsVanillaOrMissing ? Channel.VersionTest.ACCEPT_MISSING : Channel.VersionTest.exact(1)) - .simpleChannel(); + ChannelBuilder builder = ChannelBuilder.named(new ResourceLocation(modId, "crater_network")); + + if (clientAcceptsVanillaOrMissing) { + builder = builder.optionalClient(); + } + + if (serverAcceptsVanillaOrMissing) { + builder = builder.optionalServer(); + } + + return builder.simpleChannel(); } private LogicalSide getSideFromDirection(PacketDirection direction) {