Updated the lib to 1.20.1 #2

2023-06-18T04:15:11+02:00

onkoe commented

2023-06-18 04:15:11 +02:00

(Migrated from github.com)

In these short commits, I've migrated the mod to 1.20.1. Please let me know if you see any mistakes, problems, or have any other concerns you'd like me to look at! :)

hypherionmc (Migrated from github.com) reviewed 2023-06-18 04:15:11 +02:00

onkoe commented

2023-06-18 04:26:48 +02:00

(Migrated from github.com)

Ah, it's just occurred to me that Setup Instructions in the README may refer to "Usage of the Library." If that's the case, please let me know and I'll put it under another header!

Ah, it's just occurred to me that `Setup Instructions` in the README may refer to "Usage of the Library." If that's the case, please let me know and I'll put it under another header!

hypherionmc commented

2023-07-10 21:06:20 +02:00

(Migrated from github.com)

Hey, sorry I meant to respond to this.

So we have a development policy, of not dropping support for a minecraft version, if it's code compatible. This means, that if no physical code changes have to be made to support a new minecraft version, we still keep on supporting the old one as well.

So in this case, we would still support 1.20, even though 1.20.1 is the latest. That's because there are no code breaking changes between the two, and in some cases people might opt to stay with the previous version for whatever the reason.

Setup instructions do indeed mean "Usage of this library", so instructions for other modders to use this for their mods, but the building instructions you added are great.

I do still need to setup proper contribution guidelines and development guides for our mods, so everyone can be on the same page.

I will pull in your changes on the next library update, which will be soon, as I need to add some more features and fix some bugs that I found in some of the systems

Hey, sorry I meant to respond to this. So we have a development policy, of not dropping support for a minecraft version, if it's code compatible. This means, that if no physical code changes have to be made to support a new minecraft version, we still keep on supporting the old one as well. So in this case, we would still support 1.20, even though 1.20.1 is the latest. That's because there are no code breaking changes between the two, and in some cases people might opt to stay with the previous version for whatever the reason. Setup instructions do indeed mean "Usage of this library", so instructions for other modders to use this for their mods, but the building instructions you added are great. I do still need to setup proper contribution guidelines and development guides for our mods, so everyone can be on the same page. I will pull in your changes on the next library update, which will be soon, as I need to add some more features and fix some bugs that I found in some of the systems

hypherionmc commented

2023-07-31 16:12:49 +02:00

(Migrated from github.com)

Merged changes into master branch

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Dependencies

No dependencies set.

Reference: firstdarkdev/CraterLib#2