firstdarkdev/modfusioner
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix manifest removing last entry #1

Merged
wagyourtail merged 2 commits from patch-1 into master 2023-11-08 18:22:47 +01:00
Conversation 2 Commits 2 Files Changed 2 +2 -2
wagyourtail commented 2023-11-07 23:36:05 +01:00 (Migrated from github.com)
Copy Link

many text files (such as manifest.mf) require a trailing newline
so trust that files have whitespace at the end of the file for a reason.

many text files (such as manifest.mf) require a trailing newline so trust that files have whitespace at the end of the file for a reason.
wagyourtail commented 2023-11-08 00:03:19 +01:00 (Migrated from github.com)
Copy Link

cda informed me the trim was there for a reason. so + "\n"

tho this still will mangle a Whitespace file

cda informed me the trim was there for a reason. so `+ "\n"` tho this still will mangle a [Whitespace](https://esolangs.org/wiki/Whitespace) file
hypherionmc commented 2023-11-08 07:31:04 +01:00 (Migrated from github.com)
Copy Link

I only added trim() because CDA complained about the lang files getting whitespaces. So again, we blame #cda

I only added trim() because CDA complained about the lang files getting whitespaces. So again, we blame #cda
Sign in to join this conversation.
Reviewers
No Reviewers
Assignees
Clear assignees
hypherionmc
No Assignees
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Projects
Clear projects
No project
Milestone
No items
No Milestone
1 Participants
Notifications
Dependencies

No dependencies set.

Reference: firstdarkdev/modfusioner#1
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?